[webkit-reviews] review granted: [Bug 173342] Add SPI for immediate injection of user scripts : [Attachment 344785] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 11 17:07:52 PDT 2018
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 173342: Add SPI for immediate injection of user scripts
https://bugs.webkit.org/show_bug.cgi?id=173342
Attachment 344785: Patch
https://bugs.webkit.org/attachment.cgi?id=344785&action=review
--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344785
--> https://bugs.webkit.org/attachment.cgi?id=344785
Patch
LGTM with happy bots.
View in context: https://bugs.webkit.org/attachment.cgi?id=344785&action=review
> Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp:180
> + process->send(Messages::WebUserContentController::AddUserScripts({ {
userScript.identifier(), world->identifier(), userScript.userScript() } },
immediately), m_identifier.toUInt64());
s/m_identifier/Identifier()/
More information about the webkit-reviews
mailing list