[webkit-reviews] review granted: [Bug 187543] constructArray() should always allocate the requested length. : [Attachment 344745] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 187543: constructArray() should always allocate the requested length.
https://bugs.webkit.org/show_bug.cgi?id=187543

Attachment 344745: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=344745&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 344745
  --> https://bugs.webkit.org/attachment.cgi?id=344745
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=344745&action=review

r=me

> Source/JavaScriptCore/runtime/JSArray.cpp:109
> +void JSArray::eagerlyInitializeButterfly(ObjectInitializationScope& scope,
JSArray* array, unsigned initialLength)

It feels like this could perhaps have an even more specific name since it's
used in one super special place.