[webkit-reviews] review granted: [Bug 187338] [JSC] Remove getTypedArrayImpl : [Attachment 344314] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 187338: [JSC] Remove getTypedArrayImpl
https://bugs.webkit.org/show_bug.cgi?id=187338

Attachment 344314: Patch

https://bugs.webkit.org/attachment.cgi?id=344314&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 344314
  --> https://bugs.webkit.org/attachment.cgi?id=344314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344314&action=review

r=me.

> Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:315
> +	   ASSERT_NOT_REACHED();
> +	   return nullptr;

You should make this a RELEASE_ASSERT_NOT_REACHED().  It's the equivalent of
JSCell::getTypedArrayImpl() that is now removed.