[webkit-reviews] review granted: [Bug 186501] [Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably : [Attachment 344728] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 186501: [Web Animations] Make WPT test at
interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass
reliably
https://bugs.webkit.org/show_bug.cgi?id=186501

Attachment 344728: Patch

https://bugs.webkit.org/attachment.cgi?id=344728&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 344728
  --> https://bugs.webkit.org/attachment.cgi?id=344728
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344728&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:293
> +	   // When calling processKeyframeLikeObject() with the "allow lists"
flag set to false, the only alternatives
> +	   // we should expect are double and nullptr.

The only offset alternatives.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:300
> +	   // When calling processKeyframeLikeObject() with the "allow lists"
flag set to false, the only alternative
> +	   // we should expect is String.

The only easing alternative

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:305
> +	   // When calling processKeyframeLikeObject() with the "allow lists"
flag set to false, the only alternatives
> +	   // we should expect are CompositeOperation and nullptr.

The only composite alternatives

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:325
> +    RETURN_IF_EXCEPTION(scope, Exception { TypeError });

Why do you need this? Wouldn't the exception have been thrown in the inner
scope (the forEach)? I don't think anything else could throw in this scope.