[webkit-reviews] review granted: [Bug 187504] REGRESSION (r233480): Mail contents flash black when activating : [Attachment 344741] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 187504: REGRESSION (r233480): Mail contents flash black when activating
https://bugs.webkit.org/show_bug.cgi?id=187504

Attachment 344741: Patch

https://bugs.webkit.org/attachment.cgi?id=344741&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 344741
  --> https://bugs.webkit.org/attachment.cgi?id=344741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344741&action=review

Please make it build.

> Source/WebKit/ChangeLog:15
> +	   The point of hiding the web view's contents in
didCreateWindowContext
> +	   was to ensure we did not hide it before the initial background
snapshot
> +	   (so that in the case of simple app, the background snapshot contains
all
> +	   WKWebViews), but then hide it if the app was reawoken in the
background
> +	   for snapshot updates (because layer contents could be emptied at
that point),
> +	   or (at the latest) when the app itself comes back to the foreground
(for
> +	   the same reason).

This is hard to understand.