[webkit-reviews] review granted: [Bug 187358] [ews-build] EWS should unapply the patch and build ToT when patch fails to build : [Attachment 344361] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 16:39:06 PDT 2018
Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187358: [ews-build] EWS should unapply the patch and build ToT when patch
fails to build
https://bugs.webkit.org/show_bug.cgi?id=187358
Attachment 344361: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=344361&action=review
--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 344361
--> https://bugs.webkit.org/attachment.cgi?id=344361
Proposed Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=344361&action=review
> Tools/ChangeLog:3
> + [ews-build] EWS should unapply the patch and build ToT when patch
fails to build
As discussed in person, I'm not sure what the full context for this behavior.
Seems fine to land, but let's discuss the overall design soon.
> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:462
> + ExpectShell(workdir='wkdir',
> + command=["perl", "Tools/Scripts/build-webkit",
'--Release'],
This patch has a mix of single and double quotes in multiple places, could you
please clean that up?
Also, isn't the --release all lower case?
> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:476
> + command=["perl", "Tools/Scripts/build-webkit",
'--Debug'],
Ditto with regards to case.
More information about the webkit-reviews
mailing list