[webkit-reviews] review granted: [Bug 187362] [32-bit JSC tests] ASSERTION FAILED: !butterfly->propertyStorage()[-I - 1].get() under JSC::ObjectInitializationScope::verifyPropertiesAreInitialized : [Attachment 344717] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 13:29:53 PDT 2018
Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 187362: [32-bit JSC tests] ASSERTION FAILED:
!butterfly->propertyStorage()[-I - 1].get() under
JSC::ObjectInitializationScope::verifyPropertiesAreInitialized
https://bugs.webkit.org/show_bug.cgi?id=187362
Attachment 344717: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=344717&action=review
--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 344717
--> https://bugs.webkit.org/attachment.cgi?id=344717
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=344717&action=review
> Source/JavaScriptCore/runtime/ObjectInitializationScope.cpp:91
> +#else
> + return !value || !JSValue::encode(value);
> +#endif
Why are we even pretending this assertion does anything on 32-bit? Can't we
just always return true, since we don't have a concurrentJIT/concurrentGC?
More information about the webkit-reviews
mailing list