[webkit-reviews] review granted: [Bug 187515] [GLIB] Add jsc_context_get_global_object() to GLib API : [Attachment 344687] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 187515: [GLIB] Add jsc_context_get_global_object() to GLib API
https://bugs.webkit.org/show_bug.cgi?id=187515

Attachment 344687: Patch

https://bugs.webkit.org/attachment.cgi?id=344687&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 344687
  --> https://bugs.webkit.org/attachment.cgi?id=344687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344687&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   This wasn't exposed because we have convenient methods in JSCContext
to get and set properties on the global
> +	   object. However, getting the global object could be useful in some
cases, for example to give it a well known
> +	   name like 'window' in browsers and GJS.

What specifically are you planning to use it for?

Surely it's not required to give it the name "window" in Epiphany?