[webkit-reviews] review canceled: [Bug 187492] WebGL contexts unable to detect correct display upon first WebProcess creation : [Attachment 344642] Patch

[bugzilla-daemon at webkit.org]

Justin Fan <justin_fan at apple.com> has canceled	review:
Bug 187492: WebGL contexts unable to detect correct display upon first
WebProcess creation
https://bugs.webkit.org/show_bug.cgi?id=187492

Attachment 344642: Patch

https://bugs.webkit.org/attachment.cgi?id=344642&action=review




--- Comment #7 from Justin Fan <justin_fan at apple.com> ---
Comment on attachment 344642
  --> https://bugs.webkit.org/attachment.cgi?id=344642
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344642&action=review

>> Source/WebKit/Shared/WebPageCreationParameters.h:142
>> +	uint32_t displayID;
> 
> Shouldn’t this be a PlatformDisplayID?

It's a using alias for uint32_t in PlatformScreen.h; should I bring in
PlatformScreen.h or re-alias it in this header?

>>> Source/WebKit/UIProcess/WebPageProxy.cpp:6192
>>> +	 parameters.displayID = mainScreenDisplayID();
>> 
>> But this might not be the screen that at the window is on.
> 
> Get it from pageClient instead! There’s a nontrivial chance we have a
parented view at this point.

Will try!