[webkit-reviews] review granted: [Bug 187504] REGRESSION (r233480): Mail contents flash black when activating Mail : [Attachment 344658] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 9 20:42:42 PDT 2018
mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 187504: REGRESSION (r233480): Mail contents flash black when activating
Mail
https://bugs.webkit.org/show_bug.cgi?id=187504
Attachment 344658: Patch
https://bugs.webkit.org/attachment.cgi?id=344658&action=review
--- Comment #3 from mitz at webkit.org ---
Comment on attachment 344658
--> https://bugs.webkit.org/attachment.cgi?id=344658
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=344658&action=review
> Source/WebKit/UIProcess/ApplicationStateTracker.mm:100
> + m_didCreateWindowContextObserver = [notificationCenter
addObserverForName:@"_UICanvasDidActivateNotification" object:window._canvas
queue:nil usingBlock:[weakThis](NSNotification *) {
This is repeating the mistake of hardcoding a string instead of importing a
symbol.
More information about the webkit-reviews
mailing list