[webkit-reviews] review granted: [Bug 187443] Shrink various loading-related enums to shrink CachedResource : [Attachment 344607] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187443: Shrink various loading-related enums to shrink CachedResource
https://bugs.webkit.org/show_bug.cgi?id=187443

Attachment 344607: Patch

https://bugs.webkit.org/attachment.cgi?id=344607&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 344607
  --> https://bugs.webkit.org/attachment.cgi?id=344607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344607&action=review

> Source/WebCore/loader/FetchOptions.h:60
> +    String integrity;

Shouldn't we move this one up instead? I think we usually order from bigger to
smaller types.

> Source/WebCore/loader/FetchOptions.h:61
>      std::optional<DocumentIdentifier> clientIdentifier;

ditto.