[webkit-reviews] review denied: [Bug 185109] Web Inspector: Layers inspector should allow control-dragging to pan the 3D render : [Attachment 344132] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 185109: Web Inspector: Layers inspector should allow control-dragging to
pan the 3D render
https://bugs.webkit.org/show_bug.cgi?id=185109

Attachment 344132: Patch

https://bugs.webkit.org/attachment.cgi?id=344132&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 344132
  --> https://bugs.webkit.org/attachment.cgi?id=344132
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344132&action=review

Was is possible to pan before this change? The pull request for three.js
mentions right-dragging, but I can't tell what that is. Also I think geometry
in the scene shouldn't be selectable when clicking as part of a pan operation.
This would cause a user's selection to change when panning to get a better
view. r- for now, due to the selection issue.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:160
> +	   this._controls.screenSpacePanning = true;

I'd like to see a high-level explanation for why the default values for
panSpeed and screenSpacePanning aren't used. It looks like screenSpacePanning
controls the axes on which the camera pans, and the default is to pan only on
the horizontal axis of the plane parallel to the scene. That seems like strange
default behavior in any case, but maybe I'm missing something.