[webkit-reviews] review granted: [Bug 187442] Fix dump-class-layout to show bit padding, and fix issues with padding offsets : [Attachment 344533] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187442: Fix dump-class-layout to show bit padding, and fix issues with
padding offsets
https://bugs.webkit.org/show_bug.cgi?id=187442

Attachment 344533: Patch

https://bugs.webkit.org/attachment.cgi?id=344533&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 344533
  --> https://bugs.webkit.org/attachment.cgi?id=344533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344533&action=review

> Tools/lldb/dump_class_layout_unittest.py:301
> -  +1 <  4>	unsigned int bitfield3 : 1
> +  +1 <  1>	unsigned int bitfield1 : 1

This output is a progression. I find it still confusing because the size of
this bit in the bitfield is reported as 1 byte ("< 1>"). Maybe if we emitted
the number of bits of the field as "1 bit", "2 bits", et cetera when the
bitfield width is less than a byte it would help make this output easier to
understand. If we did this then we could change "<PADDING BITS: ... >" to
"<PADDING>" since we will report the number of bits of padding in the column to
the left of this message.