[webkit-reviews] review granted: [Bug 187350] REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js : [Attachment 344343] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 187350: REGRESSION: Web Inspector no longer pauses in internal injected
scripts like WDFindNodes.js
https://bugs.webkit.org/show_bug.cgi?id=187350

Attachment 344343: Patch

https://bugs.webkit.org/attachment.cgi?id=344343&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 344343
  --> https://bugs.webkit.org/attachment.cgi?id=344343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344343&action=review

r=me

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:887
> +void InspectorDebuggerAgent::setPauseForInternalScripts(ErrorString &, bool
shouldPause)

Style: pointer types and reference types should be written with no space
between the type name and the * or &
(https://webkit.org/code-style-guidelines/#pointers-cpp)

> Source/WebInspectorUI/UserInterface/Base/Setting.js:136
> +    pauseForInternalScripts: new WI.Setting("pause-for-internal-scripts",
false),

Nice cleanup.