[webkit-reviews] review granted: [Bug 187410] [Web Animations] A number of tests report an incorrect computed offset : [Attachment 344450] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 187410: [Web Animations] A number of tests report an incorrect computed
offset
https://bugs.webkit.org/show_bug.cgi?id=187410

Attachment 344450: Patch

https://bugs.webkit.org/attachment.cgi?id=344450&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 344450
  --> https://bugs.webkit.org/attachment.cgi?id=344450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344450&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:-144
> -	   if (indexOfLastKeyframeWithNonNullOffset == i - 1)
> -	       continue;

I guess you could have just made this:
if (indexOfLastKeyframeWithNonNullOffset == i - 1) {
  indexOfLastKeyframeWithNonNullOffset = i;
  continue;
}