[webkit-reviews] review granted: [Bug 185801] dump-class-layout reports wrong padding in many cases : [Attachment 344511] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 185801: dump-class-layout reports wrong padding in many cases
https://bugs.webkit.org/show_bug.cgi?id=185801

Attachment 344511: Patch

https://bugs.webkit.org/attachment.cgi?id=344511&action=review




--- Comment #28 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 344511
  --> https://bugs.webkit.org/attachment.cgi?id=344511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344511&action=review

> Tools/lldb/lldb_dump_class_layout.py:39
> +class ansi_colors:

Can we name this class using TitleCase?

> Tools/lldb/lldb_dump_class_layout.py:40
> +    OKBLUE = '\033[94m'

What is OKBLUE? Can this just be BLUE?