[webkit-reviews] review requested: [Bug 187419] [Curl] Remove unused AuthenticationManager static methods. : [Attachment 344472] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 15:59:02 PDT 2018


Basuke Suzuki <Basuke.Suzuki at sony.com> has asked  for review:
Bug 187419: [Curl] Remove unused AuthenticationManager static methods.
https://bugs.webkit.org/show_bug.cgi?id=187419

Attachment 344472: PATCH

https://bugs.webkit.org/attachment.cgi?id=344472&action=review




--- Comment #1 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Created attachment 344472

  --> https://bugs.webkit.org/attachment.cgi?id=344472&action=review

PATCH

I assume we can remove these static method declarations from
Source/WebKit/Shared/Authentication/AuthenticationManager.h:

    static void receivedCredential(const WebCore::AuthenticationChallenge&,
const WebCore::Credential&);
    static void receivedRequestToContinueWithoutCredential(const
WebCore::AuthenticationChallenge&);
    static void receivedCancellation(const WebCore::AuthenticationChallenge&);
    static void receivedRequestToPerformDefaultHandling(const
WebCore::AuthenticationChallenge&);
    static void receivedChallengeRejection(const
WebCore::AuthenticationChallenge&);


More information about the webkit-reviews mailing list