[webkit-reviews] review granted: [Bug 187370] iOS port should define HAVE_RUNLOOP_TIMER : [Attachment 344381] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 11:38:30 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 187370: iOS port should define HAVE_RUNLOOP_TIMER
https://bugs.webkit.org/show_bug.cgi?id=187370

Attachment 344381: Patch v1

https://bugs.webkit.org/attachment.cgi?id=344381&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 344381
  --> https://bugs.webkit.org/attachment.cgi?id=344381
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=344381&action=review

> Source/WTF/wtf/Platform.h:566
> +#define HAVE_DTRACE 0

It seems like HAVE_DTRACE can be removed. There are no instances of
HAVE(DTRACE) anywhere in the project. (Also Cocoa platforms do have dtrace).


More information about the webkit-reviews mailing list