[webkit-reviews] review granted: [Bug 187346] REGRESSION (r230843): Flash doesn't work; Produces blue box on page : [Attachment 344386] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 187346: REGRESSION (r230843): Flash doesn't work; Produces blue box on page
https://bugs.webkit.org/show_bug.cgi?id=187346

Attachment 344386: Patch

https://bugs.webkit.org/attachment.cgi?id=344386&action=review




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 344386
  --> https://bugs.webkit.org/attachment.cgi?id=344386
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344386&action=review

> Source/WebCore/testing/Internals.cpp:4643
> +#if PLATFORM(MAC)

Why does this code need to be macOS specific?

> LayoutTests/http/tests/plugins/plugin-allow-then-reload.html:18
> +	   if (window.testRunner)
> +	       testRunner.setBlockAllPlugins(true);

I don't think it makes sense to guard this behind if (window.testRunner)
since the test doesn't do anything useful without it, and you're exiting early
above.

> LayoutTests/http/tests/plugins/plugin-allow-then-reload.html:37
> +    console.log("number of plugins decreased after blocking: " + (test1 ?
"PASS" : "FAIL"));
> +    console.log("number of plugins increased after allowing: " + (test2 ?
"PASS" : "FAIL"));

Can't we just dump all of this into body instead?