[webkit-reviews] review granted: [Bug 187363] iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover : [Attachment 344374] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Olivia Barnett
<obarnett at apple.com>'s request for review:
Bug 187363: iPad: Scrolling with hardware keyboard while SELECT popover is
visible scrolls the page, detaches popover
https://bugs.webkit.org/show_bug.cgi?id=187363

Attachment 344374: Patch

https://bugs.webkit.org/attachment.cgi?id=344374&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344374
  --> https://bugs.webkit.org/attachment.cgi?id=344374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344374&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3645
> +    if (_assistedNodeInformation.elementType == InputType::Select)

We probably want to add other types to this list (are there other kinds of
assisted nodes that use popovers?), but this is a good start.