[webkit-reviews] review denied: [Bug 187363] iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover : [Attachment 344368] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Olivia Barnett <obarnett at apple.com>'s
request for review:
Bug 187363: iPad: Scrolling with hardware keyboard while SELECT popover is
visible scrolls the page, detaches popover
https://bugs.webkit.org/show_bug.cgi?id=187363

Attachment 344368: Patch

https://bugs.webkit.org/attachment.cgi?id=344368&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344368
  --> https://bugs.webkit.org/attachment.cgi?id=344368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686
> +    if (_assistedNodeInformation.elementType != InputType::Select) {

I don't think this is quite right, because pageup/pagedown and spacebar will
still scroll.

Instead, I think you should bail at the top of the function similar to what we
do in the isContentEditable case.