[webkit-reviews] review granted: [Bug 187356] Regression(r232886): WebsiteDataStore objects may get destroyed on a background thread : [Attachment 344353] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 13:14:15 PDT 2018


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187356: Regression(r232886): WebsiteDataStore objects may get destroyed on
a background thread
https://bugs.webkit.org/show_bug.cgi?id=187356

Attachment 344353: Patch

https://bugs.webkit.org/attachment.cgi?id=344353&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 344353
  --> https://bugs.webkit.org/attachment.cgi?id=344353
Patch

r=me

I think this is the best design for now because we generally require our API
objects to be used only on the main thread.

If we ever want to reconsider that requirement, we can reconsider this change
too.


More information about the webkit-reviews mailing list