[webkit-reviews] review granted: [Bug 187339] [GTK] Remove soup/DownloadSoupErrors.h : [Attachment 344323] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 187339: [GTK] Remove soup/DownloadSoupErrors.h
https://bugs.webkit.org/show_bug.cgi?id=187339

Attachment 344323: Patch

https://bugs.webkit.org/attachment.cgi?id=344323&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 344323
  --> https://bugs.webkit.org/attachment.cgi?id=344323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344323&action=review

> Source/WebKit/ChangeLog:7
> +

nit: Maybe just mentioned that the header is not used here.

> Source/WebKit/PlatformGTK.cmake:-372
> -    "${WEBKIT_DIR}/NetworkProcess/Downloads/soup"

Can you do the same for PlatformWPE, please?