[webkit-reviews] review granted: [Bug 187288] [GTK][WPE] Add --host option to WebDriver process : [Attachment 344173] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 187288: [GTK][WPE] Add --host option to WebDriver process
https://bugs.webkit.org/show_bug.cgi?id=187288

Attachment 344173: Patch

https://bugs.webkit.org/attachment.cgi?id=344173&action=review




--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 344173
  --> https://bugs.webkit.org/attachment.cgi?id=344173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344173&action=review

> Source/WebDriver/HTTPServer.h:60
> +    bool listen(std::optional<String> host, unsigned port);

Nit: it's not that crucial here, but const reference to the std::optional
object could be used to avoid copying the object on each call to listen() as
well as the soupServerListen() helper.

> Source/WebDriver/soup/HTTPServerSoup.cpp:46
> +	   g_set_error(error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT, "Invalid
host IP address '%s'", host.value().utf8().data());

Nit: not necessarily an IP address.