[webkit-reviews] review granted: [Bug 186690] AX: setValue on text controls should send out key events : [Attachment 344249] patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Nan Wang <n_wang at apple.com>'s
request for review:
Bug 186690: AX: setValue on text controls should send out key events
https://bugs.webkit.org/show_bug.cgi?id=186690

Attachment 344249: patch

https://bugs.webkit.org/attachment.cgi?id=344249&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 344249
  --> https://bugs.webkit.org/attachment.cgi?id=344249
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344249&action=review

> Source/WebCore/ChangeLog:9
> +	   Use Editor's insertText function when the text control element is
being

this should be just one sentence. 

"Use the Editor's insertText function when the text control element is being,
so that the InputEvent will be dispatched properly."

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1784
> +    }

should we make the following statement an else if so this follows the rest of
the pattern and we can ditch the return;