[webkit-reviews] review granted: [Bug 187318] Fix some -Wdocumentation warnings in WebKit : [Attachment 344270] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 4 07:02:48 PDT 2018
mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 187318: Fix some -Wdocumentation warnings in WebKit
https://bugs.webkit.org/show_bug.cgi?id=187318
Attachment 344270: Patch
https://bugs.webkit.org/attachment.cgi?id=344270&action=review
--- Comment #3 from mitz at webkit.org ---
Comment on attachment 344270
--> https://bugs.webkit.org/attachment.cgi?id=344270
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=344270&action=review
> Source/WebKit/ChangeLog:13
> + Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit
projects,
> + and the doc comments in the deprecated ICU API have some errors.
We should just go back to treating the ICU headers as system headers, and thus
exempt from warnings.
More information about the webkit-reviews
mailing list