[webkit-reviews] review granted: [Bug 187306] Remove Strong Confirmation Password button : [Attachment 344233] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 17:05:47 PDT 2018


Sam Weinig <sam at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 187306: Remove Strong Confirmation Password button
https://bugs.webkit.org/show_bug.cgi?id=187306

Attachment 344233: Patch

https://bugs.webkit.org/attachment.cgi?id=344233&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 344233
  --> https://bugs.webkit.org/attachment.cgi?id=344233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344233&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1096
>      AutoFillButtonType type = m_object->valueAutofillButtonType();
> -    return type == AutoFillButtonType::StrongConfirmationPassword || type ==
AutoFillButtonType::StrongPassword;
> +    return type == AutoFillButtonType::StrongPassword;

Temporary does not seem necessary.


More information about the webkit-reviews mailing list