[webkit-reviews] review granted: [Bug 187050] Remove quarantine for Webex plugin : [Attachment 344237] Using qtn_proc_init if qtn_proc_init_with_self fails

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted  review:
Bug 187050: Remove quarantine for Webex plugin
https://bugs.webkit.org/show_bug.cgi?id=187050

Attachment 344237: Using qtn_proc_init if qtn_proc_init_with_self fails

https://bugs.webkit.org/attachment.cgi?id=344237&action=review




--- Comment #11 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 344237
  --> https://bugs.webkit.org/attachment.cgi?id=344237
Using qtn_proc_init if qtn_proc_init_with_self fails

View in context: https://bugs.webkit.org/attachment.cgi?id=344237&action=review

> Source/WebKit/PluginProcess/PluginProcess.h:78
> +    bool shouldOverrideQuarantine() final;

I feel like this would be better named "shouldEnableQuarantine()" rather than
override. This really is the default case (we only "Don't Override" for WebEx).

> Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:697
> +    return m_pluginBundleIdentifier != "com.cisco.webex.plugin.gpc64";

Is there a 32-bit version we need to worry about?