[webkit-reviews] review granted: [Bug 187298] Make CallbackMap::invalidate() safe to re-enter : [Attachment 344209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 16:20:34 PDT 2018


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187298: Make CallbackMap::invalidate() safe to re-enter
https://bugs.webkit.org/show_bug.cgi?id=187298

Attachment 344209: Patch

https://bugs.webkit.org/attachment.cgi?id=344209&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 344209
  --> https://bugs.webkit.org/attachment.cgi?id=344209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344209&action=review

R=me

> Source/WebKit/UIProcess/GenericCallback.h:164
> +    HashMap<uint64_t, T> map = WTFMove(callbackMap);

I would use auto here.


More information about the webkit-reviews mailing list