[webkit-reviews] review granted: [Bug 186266] Improve window.event compliance: Should not be set when target is in shadow tree : [Attachment 344229] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 186266: Improve window.event compliance: Should not be set when target is
in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=186266

Attachment 344229: Patch

https://bugs.webkit.org/attachment.cgi?id=344229&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 344229
  --> https://bugs.webkit.org/attachment.cgi?id=344229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344229&action=review

> Source/WebCore/bindings/js/JSEventListener.cpp:163
> +	   if (!isTargetInsideShadowTree)

It probably doesn't matter but maybe we should also avoid calling
setCurrentEvent later when we restore the saved event to maintain the symmetry?