[webkit-reviews] review granted: [Bug 187303] RealtimeIncomingVideoSources: Do not call stopProducingData() when not producing data : [Attachment 344223] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 15:00:12 PDT 2018


youenn fablet <youennf at gmail.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 187303: RealtimeIncomingVideoSources: Do not call stopProducingData() when
not producing data
https://bugs.webkit.org/show_bug.cgi?id=187303

Attachment 344223: Patch

https://bugs.webkit.org/attachment.cgi?id=344223&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344223
  --> https://bugs.webkit.org/attachment.cgi?id=344223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344223&action=review

> Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h:51
> +	   stopProducingData();

We probably want to call stop() instead.


More information about the webkit-reviews mailing list