[webkit-reviews] review granted: [Bug 185257] A WKWebView in a UIViewController that is presented modally and uses a file picker will be incorrectly dismissed by the system : [Attachment 344222] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 14:50:05 PDT 2018


Tim Horton <thorton at apple.com> has granted Olivia Barnett
<obarnett at apple.com>'s request for review:
Bug 185257: A WKWebView in a UIViewController that is presented modally and
uses a file picker will be incorrectly dismissed by the system
https://bugs.webkit.org/show_bug.cgi?id=185257

Attachment 344222: Patch

https://bugs.webkit.org/attachment.cgi?id=344222&action=review




--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344222
  --> https://bugs.webkit.org/attachment.cgi?id=344222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344222&action=review

> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:288
> +	       [currentPresentedViewController
dismissViewControllerAnimated:YES completion:^{_presentationViewController =
nil;

The first statement inside the block should be on the next line.


More information about the webkit-reviews mailing list