[webkit-reviews] review granted: [Bug 187294] check-webkit-style: Run the tool without SVN client. : [Attachment 344193] PATCH

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 187294: check-webkit-style: Run the tool without SVN client.
https://bugs.webkit.org/show_bug.cgi?id=187294

Attachment 344193: PATCH

https://bugs.webkit.org/attachment.cgi?id=344193&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 344193
  --> https://bugs.webkit.org/attachment.cgi?id=344193
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=344193&action=review

> Tools/ChangeLog:6
> +	   Follow the same strategy with git.py. If it invokes exception, it
just returns False.

The description in the ChangeLog should come after the "Reviewed by" line.

The "strategy" you are referring to in git.py was added in
<https://trac.webkit.org/changeset/92440/webkit> as  speculative fix for the
"svn revision on Windows" problem. That is, it was not added to allow people to
run check-webkit-style without a Git checkout. So, I would remove the first
sentence of your ChangeLog as it does not justify this change. Please describe
that Subversion is considered optional according to the wording on
<https://webkit.org/getting-the-code/#checking-out-with-git> and
<https://webkit.org/webkit-on-windows/#installing-developer-tools> and explain
that this patch makes it so that people with only a Git checkout of WebKit that
commit using the commit-queue (or another machine with an SVN checkout) can run
check-webkit-style.