[webkit-reviews] review granted: [Bug 187255] [32-bit JSC tests] ASSERTION FAILED: !getDirect(offset) || !JSValue::encode(getDirect(offset)) : [Attachment 344201] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 12:15:57 PDT 2018


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 187255: [32-bit JSC tests] ASSERTION FAILED: !getDirect(offset) ||
!JSValue::encode(getDirect(offset))
https://bugs.webkit.org/show_bug.cgi?id=187255

Attachment 344201: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=344201&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 344201
  --> https://bugs.webkit.org/attachment.cgi?id=344201
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=344201&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   The 32-bit JIT::emit_op_create_this() needs to initialize
uninitialized properties

Do we really care about this assert on 32-bit since we don’t run concurrent
JIT/GC?


More information about the webkit-reviews mailing list