[webkit-reviews] review granted: [Bug 187277] Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools : [Attachment 344143] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 187277: Resource Load Statistics: Make
WebsiteDataStore::getAllStorageAccessEntries() call the right network process
instead of iterating over the process pools
https://bugs.webkit.org/show_bug.cgi?id=187277

Attachment 344143: Patch

https://bugs.webkit.org/attachment.cgi?id=344143&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 344143
  --> https://bugs.webkit.org/attachment.cgi?id=344143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344143&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:350
> +    if (webView) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:352
> +	   if (webPageProxy) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:26
> +#import <WebKit/WKWebView.h>

Can this be forward-declared below like so?
@class WKWebView;

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:269
> +    if (auto* parentView = mainWebView()) {

Should be an early return.