[webkit-reviews] review granted: [Bug 186129] REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work : [Attachment 344178] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 07:09:32 PDT 2018


Antoine Quint <graouts at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 186129: REGRESSION (r232186): Hardware-accelerated CSS animations using
steps() timing function no longer work
https://bugs.webkit.org/show_bug.cgi?id=186129

Attachment 344178: Patch

https://bugs.webkit.org/attachment.cgi?id=344178&action=review




--- Comment #14 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 344178
  --> https://bugs.webkit.org/attachment.cgi?id=344178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344178&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:1259
> +		   m_lastRecordedAcceleratedAction = AcceleratedAction::Stop;

I think we should clear the list of pending accelerated actions and return here
since we already know we can't actually run accelerated.


More information about the webkit-reviews mailing list