[webkit-reviews] review granted: [Bug 187253] [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave : [Attachment 344129] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 187253: [WK1] editing/spelling/markers.html is failing on recent builds of
macOS Mojave
https://bugs.webkit.org/show_bug.cgi?id=187253

Attachment 344129: Patch

https://bugs.webkit.org/attachment.cgi?id=344129&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344129
  --> https://bugs.webkit.org/attachment.cgi?id=344129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344129&action=review

> Tools/TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:228
> +	       auto resultsObject = JSValueToObject(context,
JSObjectGetPropertyAtIndex(context, resultsArray, resultIndex, nullptr),
nullptr);

Someday we should make this use the modern ObjC JSC API.