[webkit-reviews] review granted: [Bug 187139] [Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions() : [Attachment 344098] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 187139: [Web Animations] Crash in
KeyframeEffectReadOnly::applyPendingAcceleratedActions()
https://bugs.webkit.org/show_bug.cgi?id=187139

Attachment 344098: Patch

https://bugs.webkit.org/attachment.cgi?id=344098&action=review




--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 344098
  --> https://bugs.webkit.org/attachment.cgi?id=344098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344098&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:1250
> -    auto timeOffset = animation()->currentTime().value().seconds();
> +    auto currentTime = animation()->currentTime();
> +    if (!currentTime)
> +	   return;
> +
> +    auto timeOffset = currentTime.value().seconds();

I don't understand this. Is currentTime a reference?