[webkit-reviews] review granted: [Bug 187228] [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed : [Attachment 344073] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 187228: [Cocoa] Google Fonts doesn't work if the user has the requested
font locally-installed
https://bugs.webkit.org/show_bug.cgi?id=187228

Attachment 344073: Patch

https://bugs.webkit.org/attachment.cgi?id=344073&action=review




--- Comment #13 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 344073
  --> https://bugs.webkit.org/attachment.cgi?id=344073
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344073&action=review

r=me

> Source/WebCore/ChangeLog:14
> +	   doesnât set the ShouldAllowUserInstalledFonts flag. Then, in
CSSFontFaceSource::font(), a similar lookup is

Please get rid of this smart quote!

> Source/WebCore/ChangeLog:18
> +	   When the CSSFontFaceSourceâs status gets set to Success, that means
âthis is the font face source that

âthis

> Source/WebCore/ChangeLog:19
> +	   represents the @font-face blockâ but when CSSFontFaceSource::font()
returns nullptr, that means âThe font face

blockâ.  and.	âThe

> Source/WebCore/ChangeLog:20
> +	   source canât be used for some reasonâ so we then continue searching
down the font-family list (and render the

canât be used for some reasonâ