[webkit-reviews] review granted: [Bug 187254] [CMake] Use JOB_POOLS to avoid memory-hungry linker processes running at the same time : [Attachment 344112] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 187254: [CMake] Use JOB_POOLS to avoid memory-hungry linker processes
running at the same time
https://bugs.webkit.org/show_bug.cgi?id=187254

Attachment 344112: Patch

https://bugs.webkit.org/attachment.cgi?id=344112&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 344112
  --> https://bugs.webkit.org/attachment.cgi?id=344112
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344112&action=review

> Source/cmake/WebKitCommon.cmake:66
> +    if (${CMAKE_BUILD_TYPE} STREQUAL "Release")

It fails for MinSizeRel, for example. But we can't test for everything, and
when the test fails you pick the safe option, so it's good IMO.