[webkit-reviews] review granted: [Bug 187250] InstanceOf IC should do generic if the prototype is not an object. : [Attachment 344109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 10:12:28 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 187250: InstanceOf IC should do generic if the prototype is not an object.
https://bugs.webkit.org/show_bug.cgi?id=187250

Attachment 344109: Patch

https://bugs.webkit.org/attachment.cgi?id=344109&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 344109
  --> https://bugs.webkit.org/attachment.cgi?id=344109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:743
>	   if (!jsDynamicCast<JSObject*>(vm, value)) {

Fix this indentation.


More information about the webkit-reviews mailing list