[webkit-reviews] review granted: [Bug 187042] RegExp.exec returns wrong value with a long integer quantifier : [Attachment 344061] Remove the extra overflow loop, use consumeDigit, and update ChangeLog

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Sukolsak Sakshuwong
<sukolsak at gmail.com>'s request for review:
Bug 187042: RegExp.exec returns wrong value with a long integer quantifier
https://bugs.webkit.org/show_bug.cgi?id=187042

Attachment 344061: Remove the extra overflow loop, use consumeDigit, and update
ChangeLog

https://bugs.webkit.org/attachment.cgi?id=344061&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 344061
  --> https://bugs.webkit.org/attachment.cgi?id=344061
Remove the extra overflow loop, use consumeDigit, and update ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=344061&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   because once there has been overflow, undefined behavior has
occurred.

This isn’t true. Unsigned overflow is defined behavior. Signed overflow is not.
Your point below holds regardless