[webkit-reviews] review granted: [Bug 187233] JavaScriptCore: Fix clang static analyzer warnings: Assigned value is garbage or undefined : [Attachment 344053] Patch v1

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 187233: JavaScriptCore: Fix clang static analyzer warnings: Assigned value
is garbage or undefined
https://bugs.webkit.org/show_bug.cgi?id=187233

Attachment 344053: Patch v1

https://bugs.webkit.org/attachment.cgi?id=344053&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 344053
  --> https://bugs.webkit.org/attachment.cgi?id=344053
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=344053&action=review

> Source/JavaScriptCore/parser/ParserTokens.h:194
> +    JSTextPosition() { }

You can say this instead: JSTextPosition() = default;

> Source/JavaScriptCore/parser/ParserTokens.h:248
> +    JSTokenLocation() { }

Ditto.