[webkit-reviews] review requested: [Bug 187232] [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner : [Attachment 344049] [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 1 08:10:11 PDT 2018


Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 187232: [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in
test runner
https://bugs.webkit.org/show_bug.cgi?id=187232

Attachment 344049: [WPE][GTK] Fix retrieving backtrace from within flatpak
sandbox in test runner

https://bugs.webkit.org/attachment.cgi?id=344049&action=review




--- Comment #1 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 344049

  --> https://bugs.webkit.org/attachment.cgi?id=344049&action=review

[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner

The place where host tmp folder is mounted changed to /run/host/ we
need to take that into account.

Also explicitely close temporary files as relying on garbage collection to
remove them is a bad idea.

Also minor optimization avoiding to compile regex for each backtrace
retrieval.


More information about the webkit-reviews mailing list