[webkit-reviews] review granted: [Bug 182271] [WPE][GTK] Make RunLoop::TimerBase robust to its own deletion inside its source callback : [Attachment 332834] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 182271: [WPE][GTK] Make RunLoop::TimerBase robust to its own deletion
inside its source callback
https://bugs.webkit.org/show_bug.cgi?id=182271

Attachment 332834: Patch

https://bugs.webkit.org/attachment.cgi?id=332834&action=review




--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 332834
  --> https://bugs.webkit.org/attachment.cgi?id=332834
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332834&action=review

> Source/WTF/wtf/glib/RunLoopGLib.cpp:169
> +	   GRefPtr<GSource> protectedSource = timer->m_source;

We don't need a ref, the source is reffed by dispatch before calling this
callback un unreffed after, so it will be alive for sure after calling fired().