[webkit-reviews] review requested: [Bug 182303] [CMake] Make JavaScriptCore headers copies : [Attachment 332842] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 31 21:32:43 PST 2018
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 182303: [CMake] Make JavaScriptCore headers copies
https://bugs.webkit.org/show_bug.cgi?id=182303
Attachment 332842: Patch
https://bugs.webkit.org/attachment.cgi?id=332842&action=review
--- Comment #21 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 332842
--> https://bugs.webkit.org/attachment.cgi?id=332842
Patch
Ok looks like GTK and WPE are good now.
So this patch enumerates all the headers within JSC and installs them into
DerivedSources/ForwardingHeaders. The generate-forwarding-headers.pl script is
modified to remove creation of headers within JSC.
It also makes it so all the cmake files are only adding additional includes
that are port specific.
Just a warning Michael the EWS bots seemed to have trouble with this patch so
when it lands the GTK/WPE bots might need to do a clean build to get rid of the
old forwarding headers.
More information about the webkit-reviews
mailing list