[webkit-reviews] review denied: [Bug 181601] Layout Test http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html is flaky : [Attachment 332832] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied John Wilander
<wilander at apple.com>'s request for review:
Bug 181601: Layout Test
http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-a
ccess.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=181601

Attachment 332832: Patch

https://bugs.webkit.org/attachment.cgi?id=332832&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 332832
  --> https://bugs.webkit.org/attachment.cgi?id=332832
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332832&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:91
> +- (void)_hasStorageAccessEntry:(NSString *)host completionHandler:(void
(^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA),
ios(WK_IOS_TBA));

Give this a WKWebView* from which you get the pageID instead of host.  Have the
return value be an NSDictionary<_WKFrameHandle*, NSString*> to get the storage
access entries for this WKWebView.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:180
> +    boolean hasStorageAccessEntry(DOMString hostName);

What if we had this return a promise so we don't need to add more synchronous
stuff?
I think the promise should give you an array of partitions instead of just a
bool.