[webkit-reviews] review requested: [Bug 182085] Bubbles intermittently disappear from bot watchers dashboard : [Attachment 332816] Alternative patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 182085: Bubbles intermittently disappear from bot watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=182085

Attachment 332816: Alternative patch

https://bugs.webkit.org/attachment.cgi?id=332816&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 332816

  --> https://bugs.webkit.org/attachment.cgi?id=332816&action=review

Alternative patch

Simpler patch. It fixes the bug and doesn't change any functionality at all
(i.e. returns the same URL which was returned before this code change, for both
Buildbot 0.8 and 0.9).

The if (!this._firstFailedStep.logs) statement was added in
https://trac.webkit.org/changeset/220120/webkit while adding Buildbot 0.9
support, and relies on the fact that Buildbot 0.9 api doesn't have logs inside
_firstFailedStep, and so is always true for Buildbot 0.9.

We can also try to improve this method and construct the URL for the stdio.
That would be a more complex fix (making sure this._firstFailedStep is set
properly whenever this.failed is true), I am not sure if the additional benefit
is worth investing the time in.