[webkit-reviews] review requested: [Bug 174942] [Curl] Use SQLite database in cookie jar implementation for Curl port : [Attachment 332812] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 31 15:38:20 PST 2018
Christopher Reid <christopher.reid at am.sony.com> has asked for review:
Bug 174942: [Curl] Use SQLite database in cookie jar implementation for Curl
port
https://bugs.webkit.org/show_bug.cgi?id=174942
Attachment 332812: Patch
https://bugs.webkit.org/attachment.cgi?id=332812&action=review
--- Comment #4 from Christopher Reid <christopher.reid at am.sony.com> ---
Created attachment 332812
--> https://bugs.webkit.org/attachment.cgi?id=332812&action=review
Patch
Updated patch based on Alex's feedback.
I also added a flag to use the old backend with ENABLE(CURL_COOKIE_STORAGE).
I think we'd want to solely use the CookieJarDB backend in curl and remove
handling cookies with libcurl, but I'm not sure if the libcurl cookie backend
should be removed yet.
More information about the webkit-reviews
mailing list