[webkit-reviews] review granted: [Bug 182326] Should choose the best match during 'route' if there are multiple matches. : [Attachment 332802] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 31 15:00:10 PST 2018


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 182326: Should choose the best match during 'route' if there are multiple
matches.
https://bugs.webkit.org/show_bug.cgi?id=182326

Attachment 332802: Patch

https://bugs.webkit.org/attachment.cgi?id=332802&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332802
  --> https://bugs.webkit.org/attachment.cgi?id=332802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332802&action=review

> Websites/perf.webkit.org/public/v3/pages/page-router.js:32
> +	       let bestMatchingRouteName = '';

Initialize this to null instead.


More information about the webkit-reviews mailing list